Screen for searching user's posts #7622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/profile-search-posts - social-app PR #7622
Render
Destroyed
mozzius
changed the base branch from
main
to
samuel/search-lang-select-revamp
|
mozzius
force-pushed
the
samuel/search-lang-select-revamp
branch
from
715a3fc to
70a0b71
Compare
|
I just tried this out, it works really well, excellent job! I have one small suggestion: what about making the string in the menu conditional on whether you're looking at your own profile (I think it's something like social-app/src/view/com/profile/ProfileMenu.tsx Lines 218 to 221 in 1e1154a Also, for reference, this would fix #2683, #2684 and the main request in #7018. |
mozzius
force-pushed
the
samuel/profile-search-posts
branch
from
e9edb10 to
f046028
Compare
arcalinea
temporarily deployed
to
samuel/profile-search-posts - social-app PR #7622
Render
Destroyed
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7591
Fixes #2683, #2684, #7018.
Note: I changed some copy text, so did a mass find+replace to prevent translation churn. commit to review is 1e1154a
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-30.at.10.43.18.mp4
Test plan